Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetic S-V42 Smartpack Resprite(iamtheguy) #7207

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Synthetic S-V42 Smartpack Resprite(iamtheguy) #7207

wants to merge 4 commits into from
+11 −10

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Sep 24, 2024 •
edited
Loading

About the pull request

  • Big thanks to iamtheguy for spriting these!
  • Adds Dark Blue Synthetic Smartpack color(rusty like Dyer)
  • Resprites all Synthetic Smartpacks in new flavor
  • Small vendor change(PMC/UPP chooses relevant smartpack colors)

Explain why it's good for the game

Up to date sprites which include excellent exoskeleton preference(can be toggled) for visibility. Generally speaking, updating sprites is important to keep aesthetic.

Testing Photographs and Procedure

will edit in photos

Screenshots & Videos

image

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds darkblue Synthetic Smartpack for Synthetic, limits UPP/PMC Synthetic vendors to choose from relevant smartpacks.
imageadd: Adds several BEAUTIFUL Synthetic Smartpack sprites made by iamtheguy, giving a new flair and updated aesthetic.
spellcheck: changes Wey-Yu to Weyland Yutani in smartpack reference, clarifies 'synthetic' prototype smartpack
spellcheck: corrects a typo where surgical cap blue was mentioned twice
add: adds penlight for Synthetic
/:cl:

@cmss13-ci cmss13-ci bot added Sprites Remove the soul from the game. Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Sep 24, 2024
harryob
harryob approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@harryob harryob requested a review from a team October 5, 2024 11:34
@Blundir
Copy link
Contributor

Blundir commented Oct 5, 2024

Can't approve due to file interference with sprite folder reorganization

@harryob harryob added the Sprites Frozen Merge this and you will make the spritetainers angry. label Oct 5, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 17, 2024
@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@Blundir Blundir added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Merge Conflict PR can't be merged because it touched too much code Sprites Frozen Merge this and you will make the spritetainers angry. Sprites Remove the soul from the game. Stale Exempt PR can't go stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuickLode @Blundir @cm13-github @harryob